Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoCommentFixer contains 1 abstract method and must therefore be declared abstract or implement the remaining methods #124

Closed
mtracz opened this issue Jun 19, 2024 · 0 comments · Fixed by #125
Closed

NoCommentFixer contains 1 abstract method and must therefore be declared abstract or implement the remaining methods #124

mtracz opened this issue Jun 19, 2024 · 0 comments · Fixed by #125
Assignees
@mtracz
Labels
bug Something isn't working

Comments

@mtracz
Copy link
Member

mtracz commented Jun 19, 2024 •
edited
Loading

Package cannot be used with php-cs-fixer 3.59.3 (relased 16.06.2024).

breaking PR:

https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/pull/7988/files#diff-e1fb45756cd1d53b6d67072d8a026692c07af55617018229b0bf4ab6c22e3e53

Output error:

Fatal error: Class Blumilk\Codestyle\Fixers\NoCommentFixer contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PhpCsFixer\Fixer\ConfigurableFixerInterface::configure) in /application/vendor/blumilksoftware/codestyle/src/Fixers/NoCommentFixer.php on line 19

NoCommentFixer implements ConfigurableFixerInterface which require configure method which has been deleted in parent (AbstractFixer) class in 3.59.3 release.
Instead of we can use ConfigurableFixerTrait which contains configure method.
Also we need to rename getConfigurationDefinition to createConfigurationDefinition.
@mtracz mtracz added the bug Something isn't working label Jun 19, 2024
@mtracz mtracz self-assigned this Jun 19, 2024
@mtracz mtracz mentioned this issue Jun 19, 2024
Merged
@krzysztofrewak krzysztofrewak mentioned this issue Jun 19, 2024
Closed
mtracz added a commit that referenced this issue Jun 20, 2024
@mtracz
#124 - fix NoCommentFixer.php after 3.59.3 php cs fixer release (#125)
fc04101 
* fix NoCommentFixer.php after 3.59.3 php cs fixer release

* bump friendsofphp/php-cs-fixer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtracz mtracz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#124 - fix NoCommentFixer.php after 3.59.3 php cs fixer release blumilksoftware/codestyle
1 participant
@mtracz