2.3.18.15 #3
Open
2.3.18.15 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a test to ensure SQL injection is not possible via range queries (Rails 2.3 is not affected, was CVE-2014-3483 for 4.x)
A breaking change was introduced in Ruby 2.2. Please see https://bugs.ruby-lang.org/issues/10314
When running on Ruby 2.2. Context here http://stackoverflow.com/questions/21184960/ruby-digestdigest-is-deprecated-use-digest/21185739#21185739 and here ruby/ruby#446
…ity in ActiveSupport::JSON.encode)
XML documents that are too deep can cause an stack overflow, which in turn will cause a potential DoS attack. CVE-2015-3227 Conflicts: activesupport/lib/active_support/xml_mini.rb Conflicts: activesupport/lib/active_support/xml_mini/jdom.rb activesupport/lib/active_support/xml_mini/rexml.rb
…ent with excessive depth (CVE-2015-3227) Conflicts: activesupport/test/xml_mini/jdom_engine_test.rb activesupport/test/xml_mini/rexml_engine_test.rb
…r when parsing an XML document with excessive depth (CVE-2015-3227) Conflicts: activesupport/test/xml_mini/jdom_engine_test.rb
…using jruby/warbler
…private gemserver
…memory leak in Mime::EXTENSION_LOOKUP (only affected 2.3)
…when the association has allow_destroy: false This test is all we can do for Rails 2.3 in regard to [CVE-2015-7577] Nested attributes rejection proc bypass in Active Record. In Rails 3+ you could skip over a :reject_if proc when the nested association had :allow_destroy => false and you're updating an existing record with :_destroy => 1. This might be used to change a record that the developer considers to be off limits due to the :reject_if condition. However, the Rails 2.3 API defines that :reject_if is never called for existing records, only for new records. Hence the developer cannot trust in any protection from :reject_if for existing record. The only (slightly awkward) test we can write for Rails 2.3 is that new records with :_destroy => true are immediately destroyed, even if :allow_destroy is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up from 2.3.18.10
For changes: https://makandracards.com/railslts/23706-rails-lts-2-3-changelog