Update ArrayString to use union and prepare for 0.5 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't of much use at the moment, but future Rust features could mean we can use it.
Raw pointer taking should go through the MaybeUninit wrappers around the arrays anyway, when it is partially uninitialized, which it often is. The remaining .as_ptr() and .as_slice() methods on Array is only used on a fully initialized array in ArrayString::from_byte_string
This is the "real" union solution, and ArrayString can use it since its backing array is Copy. Unfortunately, we'll have to use the Copy bound on the type, making it "viral" and visible in the user API.
bluss
force-pushed
the
maybe-uninit-for-0.5
branch
4 times, most recently
from
33952cf to
1ecbea9
Compare
Rust 1.24 is on debian stable. It is compatible with crossbeam (Rust 1.26), the rdep with most downloads.
bluss
force-pushed
the
maybe-uninit-for-0.5
branch
from
1ecbea9 to
74745a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unionin ArrayString, since it only has a Copy backing array. Unfortunately we have to copy this bound to all where clauses of an ArrayString, but we now have the proper solution in place.. for ArrayString.