Add safety note to the some unsafe functions. #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly just moving comment and adding some additional informations. Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
bluss
reviewed
Mar 23, 2021
Comment on lines
+526
to
+528
| /// number of “valid” elements in the vector. This new value | ||
| /// might not correspond to the actual number of elements in the | ||
| /// vector which many functions rely to be true. Use with care. |
There was a problem hiding this comment.
I wasn't able to just merge this since the way it's written here makes it sound as though it's ok to set the length to a value that does not correspond to the number of initialized elements in the vector. That's not really true: length must be set to a correct value, but the caller is responsible for checking the value (thus the method is unsafe).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just moving comment and adding some additional informations.
Signed-off-by: Hanif Bin Ariffin hanif.ariffin.4326@gmail.com