(WIP) Add no_std support #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jturner314
force-pushed
the
no_std
branch
2 times, most recently
from
9d5afa1
to
d62afcd
Compare
|
Hey, if you want to test no_std, take a look at this GitHub action here: https://github.com/rust-cv/eight-point/blob/master/.github/workflows/no-std.yml |
|
indexmap has a test for compilation as no-std, too https://github.com/bluss/indexmap/blob/master/.travis.yml |
|
It looks like this is backwards compatible as long as only disabling std requires Rust 1.36; so the supported version does not need to change. |
|
@jturner314 Are you interested in carrying this on? If not, I might use your branch as a starting point for a new PR. |
|
@vadixidav Please feel free to take over the effort. I don't have much time to work on this. |
|
Alright, I am going to pick this up today. I will make another PR once I am done. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
no_stdsupport. In theno_stdcase, the available CPU features are determined at compile time instead of run time.The WIP portion of this PR is adding tests for the
no_stdsupport.