Use ManuallyDrop instead of mem::forget in into_inner #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtunnels
force-pushed
the
refactor-mem-forget
branch
from
bb558a9 to
8e62efa
Compare
willtunnels
force-pushed
the
refactor-mem-forget
branch
from
8e62efa to
a573ce9
Compare
konsumlamm
suggested changes
Aug 8, 2021
Amanieu
reviewed
Aug 8, 2021
|
Any chance of a release that includes this patch? We'd like to enable 'field retagging' in Miri by default (Cc rust-lang/miri#2528), which is needed to correctly reflect all the |
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.