Add IU, mol, m #17
Closed
Add IU, mol, m #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding units IU, mol, m + some corrections
AFoletti
requested changes
Jan 5, 2024
| @@ -574,7 +582,7 @@ Datum Version Autor | |||
| <xs:documentation xml:lang="en">gram/square metre</xs:documentation> | |||
| </xs:annotation> | |||
| </xs:enumeration> | |||
| <xs:enumeration value="l/m2"> | |||
| <xs:enumeration value="m3/m2"> | |||
There was a problem hiding this comment.
Never saw this combination used anywhere in my life. Granted, it's not wrong per se and I understand the effort aimed at using basic units already defined in the standard, but I find this instance highly confusing.
Suggestion: keep l/m2
| @@ -544,7 +544,7 @@ Datum Version Autor | |||
| </xs:enumeration> | |||
| <xs:enumeration value="kg/pc"> | |||
| <xs:annotation> | |||
| <xs:documentation xml:lang="de">KiloGramm/Stück</xs:documentation> | |||
| <xs:documentation xml:lang="de">Kilogramm/Stück</xs:documentation> | |||
There was a problem hiding this comment.
This was fixed with #14
I think this branch needs a rebase before merging
There was a problem hiding this comment.
Thanks for the hint
|
deprecated by newer pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding units IU, mol, m + some corrections