SolrConnection should have a string representation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During to the `SolrService/SolrConnection` refactoring, the method `__toString()` is missing, but still called in `Classes/IndexQueue/FrontendHelper/PageIndexer.php` (line 303) causing in Fatal (but recoverable) PHP Errors while indexing. The patch adds the missing method again, which works just fine for our use cases (TYPO3 v9, solr-master)
bmack
pushed a commit
that referenced
this pull request
Feb 23, 2022
If using PHP 8.1, the following exception is thrown ``` PHP Runtime Deprecation Notice: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in ``` Cast the value to a string to avoid the exception
bmack
pushed a commit
that referenced
this pull request
Mar 30, 2023
… type int, string given Fixes: TYPO3-Solr#3267
bmack
pushed a commit
that referenced
this pull request
May 16, 2024
Fixes issue after PHPStan 1.11 upgrade: ``` Parameter #1 $boost of class ApacheSolrForTypo3\Solr\Domain\Search\Score\Score constructor expects float, string given. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During to the
SolrService/SolrConnectionrefactoring, the method__toString()is missing, but still called inClasses/IndexQueue/FrontendHelper/PageIndexer.php(line 303) causing in Fatal (but recoverable) PHP Errors while indexing.The patch adds the missing method again, which works just fine for our use cases (TYPO3 v9, solr-master)