Skip to content

fix: correct relative path depth for module data and template references#23

Merged
bmadcode merged 1 commit intobmad-code-org:mainfrom
arcaven:fix/broken-refs-wrong-depth
Feb 12, 2026
Merged

fix: correct relative path depth for module data and template references#23
bmadcode merged 1 commit intobmad-code-org:mainfrom
arcaven:fix/broken-refs-wrong-depth

Conversation

@arcaven
Copy link
Contributor

@arcaven arcaven commented Feb 8, 2026

Summary

  • Fix 17 broken file references across 12 module workflow step files
  • All references used ../../data/ or ../../templates/ but actual files are at ../data/ or ../templates/ (one ../ too many)
  • Also corrects agent-spec-template.md from templates/ to data/ where it actually lives

Found by

File reference validator (PR #8)

Fixes #9, #10, #11, #12, #13, #14

Files changed

File Refs fixed
steps-c/step-01-load-brief.md 4
steps-c/step-02-structure.md 1
steps-c/step-03-config.md 1
steps-c/step-04-agents.md 2
steps-c/step-05-workflows.md 1
steps-b/step-13-review.md 1
steps-b/step-14-finalize.md 1
steps-e/step-01-load-target.md 1
steps-v/step-02-file-structure.md 1
steps-v/step-03-module-yaml.md 1
steps-v/step-04-agent-specs.md 2
steps-v/step-05-workflow-specs.md 1

Why is this safe

These are frontmatter path corrections only. No logic, no step content, no workflow behavior changes. Each fix points the reference to the file that already exists at the correct location.

Summary by CodeRabbit

  • Chores
    • Updated relative file path references across workflow step configuration files to standardize template and data file loading locations. Changes affect path resolution for module standards, YAML conventions, agent specifications, and workflow specifications across multiple workflow modules.

All module workflow steps referenced ../../data/ and ../../templates/ but the
actual files are at ../data/ and ../templates/ (one level closer). Also corrects
agent-spec-template.md references from templates/ to data/ where it actually lives.

Fixes bmad-code-org#9, bmad-code-org#10, bmad-code-org#11, bmad-code-org#12, bmad-code-org#13, bmad-code-org#14
Found by file reference validator (PR bmad-code-org#8)
@coderabbitai
Copy link

coderabbitai bot commented Feb 8, 2026

Walkthrough

This pull request systematically corrects relative file path references across multiple workflow step definition files in the src/workflows/module/ directory. Path adjustments change template and data file references from two-level-up (../../) to one-level-up (../) relative paths, and reposition certain template files from templates/ to data/ directories to align with actual file locations.

Changes

Cohort / File(s) Summary
Brief template path corrections
src/workflows/module/steps-b/step-13-review.md, src/workflows/module/steps-b/step-14-finalize.md
Updated briefTemplateFile reference from ../../templates/brief-template.md to ../templates/brief-template.md, reducing relative path depth by one directory level.
Module standards file path corrections
src/workflows/module/steps-c/step-01-load-brief.md, src/workflows/module/steps-c/step-02-structure.md, src/workflows/module/steps-e/step-01-load-target.md, src/workflows/module/steps-v/step-02-file-structure.md
Updated moduleStandardsFile reference from ../../data/module-standards.md to ../data/module-standards.md across all four files.
Module YAML conventions file path corrections
src/workflows/module/steps-c/step-03-config.md, src/workflows/module/steps-v/step-03-module-yaml.md
Updated moduleYamlConventionsFile reference from ../../data/module-yaml-conventions.md to ../data/module-yaml-conventions.md.
Agent specification and architecture file path corrections
src/workflows/module/steps-c/step-01-load-brief.md, src/workflows/module/steps-c/step-04-agents.md, src/workflows/module/steps-v/step-04-agent-specs.md
Updated agentSpecTemplate from ../../templates/agent-spec-template.md to ../data/agent-spec-template.md and agentArchitectureFile from ../../data/agent-architecture.md to ../data/agent-architecture.md.
Workflow specification template path corrections
src/workflows/module/steps-c/step-01-load-brief.md, src/workflows/module/steps-c/step-05-workflows.md, src/workflows/module/steps-v/step-05-workflow-specs.md
Updated workflowSpecTemplate reference from ../../templates/workflow-spec-template.md to ../templates/workflow-spec-template.md.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related issues

Poem

🐰 Paths once tangled, now made right,
Two levels up becomes just one in sight,
Data and templates in their place,
References now resolve with grace!

🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (2 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The PR successfully addresses issue #9 by correcting all four module-standards.md references from ../../data/ to ../data/. However, the PR claims to fix issues #10-#14 but only shows details for #9; verification of other issues is inconclusive. Confirm that all changes in the PR comprehensively address the requirements for issues #10, #11, #12, #13, and #14, or clarify which issues are actually fixed by this PR.
Out of Scope Changes check ❓ Inconclusive The PR contains changes beyond issue #9, including corrections to agent-spec-template, workflow-spec-template, module-yaml-conventions, and agent-architecture references. These changes are not detailed in the provided issue #9 requirements. Verify that the additional path corrections for template and architecture files are covered by issues #10-#14, or clarify if they are scope creep.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: correcting relative path depths for module data and template references across multiple workflow step files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bmadcode bmadcode merged commit 0187d18 into bmad-code-org:main Feb 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken ref: module-standards.md referenced with wrong path depth

2 participants