Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label clarifications #1981

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Label clarifications #1981

merged 1 commit into from
Feb 18, 2024

Conversation

mikeboensel
Copy link
Contributor

No description provided.

@bmaltais
Copy link
Owner

I think this is a useful PR but this file is maintained by kohya_ss under his sd-scripts repo. Please open a PR with him directly and when he merge it in his main branch I will pick it up in mine.

@mikeboensel
Copy link
Contributor Author

I just took a look over there and don't see a corresponding file (checked main/dev/stable cascade branches).
https://github.com/kohya-ss/sd-scripts/tree/dev/library

I looked at the file history and it seems like you created it, not kohya_ss (https://github.com/bmaltais/kohya_ss/commits/master/library/class_advanced_training.py)

Maybe I'm missing something tho?

@bmaltais
Copy link
Owner

Haha, I can’t even remember all I added . Heh. Ok, I will merge it in.

@bmaltais bmaltais changed the base branch from master to dev February 18, 2024 17:20
@bmaltais bmaltais merged commit 2d0ed8e into bmaltais:dev Feb 18, 2024
@mikeboensel mikeboensel deleted the patch-4 branch February 20, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants