Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmdb: Silence missing initializers error on clang #107

Merged
merged 1 commit into from
Feb 13, 2017
Merged

lmdb: Silence missing initializers error on clang #107

merged 1 commit into from
Feb 13, 2017

Conversation

lmb
Copy link
Contributor

@lmb lmb commented Feb 13, 2017

Compiling this package on clang currently generates the following bogus warnings:

$ go test ./lmdb
# github.com/bmatsuo/lmdb-go/lmdb
lmdb/mdb.c:9100:20: warning: missing field 'mc_backup' initializer [-Wmissing-field-initializers]
lmdb/mdb.c:9258:18: warning: missing field 'mc_txn' initializer [-Wmissing-field-initializers]
ok      github.com/bmatsuo/lmdb-go/lmdb    0.380s

Add a flag to the CGO implementation which suppresses this output. See https://bugs.llvm.org//show_bug.cgi?id=21689 for the upstream bug.

Compiling this package on clang currently generates the following bogus warnings:

    $ go test ./lmdb
    # github.com/bmatsuo/lmdb-go/lmdb
    lmdb/mdb.c:9100:20: warning: missing field 'mc_backup' initializer [-Wmissing-field-initializers]
    lmdb/mdb.c:9258:18: warning: missing field 'mc_txn' initializer [-Wmissing-field-initializers]
    ok      github.com/bmatsuo/lmdb-go/lmdb    0.380s

Add a flag to the CGO implementation which suppresses this output. See https://bugs.llvm.org//show_bug.cgi?id=21689 for the upstream bug.
@bmatsuo
Copy link
Owner

bmatsuo commented Feb 13, 2017

Looks good. Thanks @lmb

@bmatsuo bmatsuo merged commit ff4ccdd into bmatsuo:master Feb 13, 2017
bmatsuo added a commit that referenced this pull request Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants