Do not create telemetry TaskSchedule for production systems.

closes pulp#3015

.github/template_gitref

@@ -1 +1 @@
-2021.08.26-160-g672272f
+2021.08.26-161-g7cd6cdb

.github/workflows/scripts/install.sh

@@ -17,11 +17,6 @@ source .github/workflows/scripts/utils.sh
 
 export PULP_API_ROOT="/pulp/"
 
-if [[ "$TEST" = "docs" || "$TEST" = "publish" ]]; then
-  pip install psycopg2-binary
-  pip install -r doc_requirements.txt
-fi
-
 cd .ci/ansible/
 
 TAG=ci_build
@@ -131,6 +126,11 @@ fi
 
 ansible-playbook build_container.yaml
 ansible-playbook start_container.yaml
+
+if [[ "$TEST" = "docs" || "$TEST" = "publish" ]]; then
+  pip install psycopg2-binary
+  cmd_prefix bash -c "cd pulpcore; pip install -r doc_requirements.txt"
+fi
 echo ::group::SSL
 # Copy pulp CA
 sudo docker cp pulp:/etc/pulp/certs/pulp_webserver.crt /usr/local/share/ca-certificates/pulp_webserver.crt

.github/workflows/scripts/script.sh

@@ -33,9 +33,8 @@ if [[ "$TEST" = "docs" ]]; then
     pip install towncrier==19.9.0
     towncrier --yes --version 4.0.0.ci
   fi
-  cd docs
-  make PULP_URL="$PULP_URL" diagrams html
-  tar -cvf docs.tar ./_build
+  cmd_prefix bash -c "cd pulpcore/docs; make diagrams html; tar -cvf docs.tar ./_build"
+  docker cp pulp:/pulpcore//docs/docs.tar docs.tar
   cd ..
 
   if [ -f $POST_DOCS_TEST ]; then

CHANGES/3015.bugfix

@@ -0,0 +1 @@
+Do not create telemetry TaskSchedule for production systems.

pulpcore/app/apps.py

@@ -212,14 +212,11 @@ def ready(self):
         super().ready()
         from . import checks  # noqa
 
+        _configure_telemetry(self.apps)
+
         post_migrate.connect(
             _populate_system_id, sender=self, dispatch_uid="populate_system_id_identifier"
         )
-        post_migrate.connect(
-            _populate_telemetry_periodic_task,
-            sender=self,
-            dispatch_uid="populate_telemetry_periodic_task_identifier",
-        )
 
 
 def _populate_access_policies(sender, apps, verbosity, **kwargs):
@@ -265,14 +262,24 @@ def _populate_system_id(sender, apps, verbosity, **kwargs):
         SystemID().save()
 
 
-def _populate_telemetry_periodic_task(sender, apps, **kwargs):
-    TaskSchedule = apps.get_model("core", "TaskSchedule")
-    task_name = "pulpcore.app.tasks.telemetry.post_telemetry"
-    dispatch_interval = timedelta(days=1)
-    name = "Post Anonymous Telemetry Periodically"
-    TaskSchedule.objects.update_or_create(
-        name=name, defaults={"task_name": task_name, "dispatch_interval": dispatch_interval}
-    )
+def _configure_telemetry(apps):
+    from django.db import connection
+    from pulpcore.app.util import get_telemetry_posting_url, PRODUCTION_URL
+
+    if "core_taskschedule" in connection.introspection.table_names():
+        url = get_telemetry_posting_url()
+        TaskSchedule = apps.get_model("core", "TaskSchedule")
+        task_name = "pulpcore.app.tasks.telemetry.post_telemetry"
+        dispatch_interval = timedelta(days=1)
+        name = "Post Anonymous Telemetry Periodically"
+        # Initially only dev systems receive posted data.
+        if url == PRODUCTION_URL:
+            TaskSchedule.objects.filter(task_name=task_name).delete()
+        else:
+            TaskSchedule.objects.update_or_create(
+                name=name, defaults={"task_name": task_name, "dispatch_interval": dispatch_interval}
+            )
+    connection.close()
 
 
 def _populate_roles(sender, apps, verbosity, **kwargs):

pulpcore/app/tasks/telemetry.py

@@ -7,6 +7,7 @@
 from asgiref.sync import sync_to_async
 
 from pulpcore.app.apps import pulp_plugin_configs
+from pulpcore.app.util import get_telemetry_posting_url
 from pulpcore.app.models import SystemID
 from pulpcore.app.models.status import ContentAppStatus
 from pulpcore.app.models.task import Worker
@@ -15,10 +16,6 @@
 logger = logging.getLogger(__name__)
 
 
-PRODUCTION_URL = "https://analytics-pulpproject-org.pulpproject.workers.dev/"
-DEV_URL = "https://dev-analytics-pulpproject-org.pulpproject.workers.dev/"
-
-
 async def _num_hosts(qs):
     hosts = set()
     items = await sync_to_async(list)(qs.all())
@@ -67,20 +64,8 @@ async def _system_id():
     return {"system_id": str(system_id_entry.pk)}
 
 
-def _get_posting_url():
-    for app in pulp_plugin_configs():
-        if ".dev" in app.version:
-            return DEV_URL
-
-    return PRODUCTION_URL
-
-
 async def post_telemetry():
-    url = _get_posting_url()
-
-    if url == PRODUCTION_URL:
-        return  # Initially only dev systems receive posted data. If we got here, bail.
-
+    url = get_telemetry_posting_url()
     data = {}
 
     awaitables = (

pulpcore/app/util.py

@@ -19,6 +19,9 @@
 # a little cache so viewset_for_model doesn't have iterate over every app every time
 _model_viewset_cache = {}
 
+PRODUCTION_URL = "https://analytics-pulpproject-org.pulpproject.workers.dev/"
+DEV_URL = "https://dev-analytics-pulpproject-org.pulpproject.workers.dev/"
+
 
 def get_url(model):
     """
@@ -243,3 +246,11 @@ def gpg_verify(public_keys, signature, detached_data=None):
         if not verified.valid:
             raise InvalidSignatureError(_("The signature is not valid."), verified=verified)
     return verified
+
+
+def get_telemetry_posting_url():
+    for app in pulp_plugin_configs():
+        if ".dev" in app.version:
+            return DEV_URL
+
+    return PRODUCTION_URL