Skip to content

Commit

Permalink
Updated comments
Browse files Browse the repository at this point in the history
  • Loading branch information
bmingles committed Dec 6, 2023
1 parent 45283ce commit 04b3f85
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions packages/components/scss/bootstrap_overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -186,11 +186,11 @@ $custom-control-indicator-disabled-bg: $gray-800;
$custom-control-indicator-checked-disabled-bg: $gray-800;
$custom-control-label-disabled-color: $gray-400;

//Custom Select
// This needs to dynamically pull from --dh-color-gray-600, but this doesn't
// work with an inline SVG. We'll need to wrap our <select> instances with a
// wrapper and implement the arrow icons in a different way. To be addressed
// by #1634
// The $custom-select-indicator variable is used by Bootstrap to provide the
// icon for the select dropdown. Inline svgs can't use CSS variables, so we hard
// code the color to #929192 (the default value of --dh-color-gray-600). PR #1651
// overrides this icon altogether for known dropdowns, so technically we may not
// need this, but it's here in case there are any remaining instances.
$custom-select-indicator-color: #929192;
$custom-select-bg-size: 16px 16px;
//dhSort icon encoded
Expand Down Expand Up @@ -261,7 +261,8 @@ $form-feedback-icon-invalid: str-replace(
'%23'
);

// Unused but needs to be defined for sass to compile _variables
// This section of variables is not consumed directly by DH, but they need to be
// defined for sass to compile _variables
$table-dark-bg: $gray-800;
$table-dark-accent-bg: var(--dh-color-highlight-hover);
$table-dark-hover-bg: var(--dh-color-highlight-active);
Expand Down

0 comments on commit 04b3f85

Please sign in to comment.