Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back error messages when unable to detect workspaces #586

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

bmish
Copy link
Owner

@bmish bmish commented May 11, 2023

Follow-up to #379. That PR stopped using the getWorkspaces() function, but didn't delete it, and didn't copy over the error handling for it to the replacement functions.

In this PR, I have deleted getWorkspaces() as it was unused, and copied over the error handling for it to the live code, and updated the tests to test the live code.

The error messages are for unexpected situations encountered when attempting to detect workspaces.

@bmish bmish added the bug Something isn't working label May 11, 2023
@bmish bmish requested a review from ddzz May 11, 2023 17:45
@bmish bmish merged commit 99a4f7d into main May 11, 2023
@bmish bmish deleted the fix-edge-cases branch May 11, 2023 17:51
@bmish bmish changed the title Add back error messages when unable to detect workspaces Add back error messages when unable to detect workspaces May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant