Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node API #591

Merged
merged 1 commit into from
May 20, 2023
Merged

Add Node API #591

merged 1 commit into from
May 20, 2023

Conversation

bmish
Copy link
Owner

@bmish bmish commented May 11, 2023 •
edited
Loading

Fixes #204.

See the README for more info on the new CDVC class that we now export.

Includes various refactorings:

  • Data models
  • readonly arrays

TODO

  • Cleanup check() function
  • Stop testing so many internal helper functions in test/lib/dependency-versions-test.ts as this makes it hard to refactor. Test using the public CDVC API instead.

@bmish bmish added the enhancement New feature or request label May 11, 2023
@bmish bmish force-pushed the node-api branch 2 times, most recently from 70b0fcd to 6b9fb92 Compare May 11, 2023 21:45
@bmish bmish changed the title Add node API Add Node API May 11, 2023
@bmish bmish marked this pull request as draft May 11, 2023 23:05
@bmish bmish force-pushed the node-api branch 3 times, most recently from 41bf347 to 1739288 Compare May 12, 2023 16:36
@ddzz
Copy link
Collaborator

ddzz commented May 12, 2023

Node 12 needs to be removed from CI

@bmish
Copy link
Owner Author

bmish commented May 12, 2023 •
edited
Loading

Node 12 needs to be removed from CI

Yes, will do that in #495 once I have gathered up breaking changes, but I'd like to get this new feature in in a minor version first.

@bmish bmish marked this pull request as ready for review May 12, 2023 17:24
@bmish bmish force-pushed the node-api branch 2 times, most recently from 0366ae9 to 2c24779 Compare May 12, 2023 17:31
@bmish bmish requested a review from ddzz May 12, 2023 20:42
@bmish bmish force-pushed the node-api branch 2 times, most recently from 3ac14cd to 83661c3 Compare May 12, 2023 20:57
ddzz
ddzz reviewed May 13, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
ddzz
ddzz reviewed May 13, 2023
View reviewed changes
lib/check.ts Show resolved Hide resolved
@bmish bmish marked this pull request as draft May 13, 2023 19:39
@bmish bmish force-pushed the node-api branch 8 times, most recently from 1863f70 to d55b338 Compare May 19, 2023 17:16
@bmish bmish marked this pull request as ready for review May 19, 2023 17:25
@bmish bmish force-pushed the node-api branch 6 times, most recently from d82e9b1 to d4a871c Compare May 20, 2023 16:55
@bmish bmish merged commit c4d91ff into main May 20, 2023
@bmish bmish deleted the node-api branch May 20, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddzz ddzz ddzz left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement NodeJS API
2 participants
@bmish @ddzz