Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): replace eslint-plugin-square #539

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Oct 22, 2024

Issue

  1. eslint-plugin-square says "It is generally not recommended for public usage outside of Square.".
  2. eslint-plugin-square offers no flat config. flat configuration is however the standard for ESLint v9 and later, and so remaining with this plugin would prevent migration.

Change

@MikeMcC399 MikeMcC399 force-pushed the remove/eslint-plugin-square branch from 81f295c to 287ee7d Compare October 22, 2024 13:18
@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 22, 2024 13:31
@ddzz ddzz merged commit bac3183 into bmish:main Oct 22, 2024
6 checks passed
@MikeMcC399 MikeMcC399 deleted the remove/eslint-plugin-square branch October 22, 2024 14:02
@bmish bmish added the internal label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants