Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude assets from classmaps #393

Merged
merged 3 commits into from
Aug 4, 2024
Merged

Exclude assets from classmaps #393

merged 3 commits into from
Aug 4, 2024

Conversation

villfa
Copy link
Collaborator

@villfa villfa commented Jun 20, 2024

composer dump-autoload --optimize --strict-psr --no-scripts failed with this message:

Class Acme\Bar located in ./tests/Unit/Assets/Bar.php does not comply with psr-4 autoloading standard (rule: Churn\Tests\ => ./tests). Skipping.
Class Acme\Baz located in ./tests/Unit/Assets/Baz.php does not comply with psr-4 autoloading standard (rule: Churn\Tests\ => ./tests). Skipping.
Class Acme\Foo located in ./tests/Unit/Assets/Foo.php does not comply with psr-4 autoloading standard (rule: Churn\Tests\ => ./tests). Skipping.
Class Acme\Qux located in ./tests/Unit/Assets/Qux.inc does not comply with psr-4 autoloading standard (rule: Churn\Tests\ => ./tests). Skipping.
Class Acme\Deep2 located in ./tests/Unit/Assets2/DeepAssets/Deep2.php does not comply with psr-4 autoloading standard (rule: Churn\Tests\ => ./tests). Skipping.
Class Acme\Deep located in ./tests/Unit/Assets2/DeepAssets/Deep.php does not comply with psr-4 autoloading standard (rule: Churn\Tests\ => ./tests). Skipping.
Class Acme\Different located in ./tests/Unit/Assets2/DeepAssets/Different.php does not comply with psr-4 autoloading standard (rule: Churn\Tests\ => ./tests). Skipping.
Class Acme\Foo2 located in ./tests/Unit/Assets2/Foo2.php does not comply with psr-4 autoloading standard (rule: Churn\Tests\ => ./tests). Skipping.
Class Acme\Qux2 located in ./tests/Unit/Assets2/Qux2.inc does not comply with psr-4 autoloading standard (rule: Churn\Tests\ => ./tests). Skipping.

Psalm also failed with this error:

Uncaught TypeError: PhpParser\Lexer\Emulative::__construct(): Argument #1 ($phpVersion) must be of type ?PhpParser\PhpVersion, array given, called in /home/runner/work/churn-php/churn-php/vendor-bin/psalm/vendor/vimeo/psalm/src/Psalm/Internal/Provider/StatementsProvider.php on line 402 and defined in /home/runner/work/churn-php/churn-php/vendor/bin/.phpunit/phpunit-9.6-1/vendor/nikic/php-parser/lib/PhpParser/Lexer/Emulative.php:38

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (f072536) to head (d17fd38).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   99.12%   99.11%   -0.01%     
==========================================
  Files          56       56              
  Lines         913      906       -7     
==========================================
- Hits          905      898       -7     
  Misses          8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@villfa villfa force-pushed the fix-build branch 2 times, most recently from 5b5e85a to d7c3ee4 Compare June 20, 2024 15:11
@villfa villfa merged commit 556a2ef into bmitch:master Aug 4, 2024
34 checks passed
@villfa villfa deleted the fix-build branch August 4, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant