-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
providing pronunciation hints #917
Comments
I'm pretty sure this would also affect Geocoding responses. For example if you enter a zip code or say a city or state, it reads back the location. |
Yes, we would want incorrect pronunciations to be fixed for that as well, if possible. |
This will be in the next yap 4.3.0 beta |
yap 4.3.0 beta 8 was released. |
Alas I'm not having any luck getting pronunciation hints to work. The example in the documentation is for Yakima:
But UkEEma is what Twilio/yap currently says, and isn't correct. It should be YAKima (/ˈjækɪmɑː/). I tried various phonetic spellings (YAKima, Yaakima, etc), but none of them changed what was spoken. Then I tried just "Yak" as the target, to see if it was getting picked up at all, and Twilio/yap is still saying UkEEma. Should I be doing something different? |
Is this still not working? |
Looks like there is a bug in the I may also have had a caching problem, but at least now it's working for the first pair. |
Interesting, because |
The "all occurrences" part is ok. Here's the function:
So we iterate through the pronunciations, and return after processing the first item. So you'd fix all the occurrences of "Sequim", but not "Yakima", for those two pronunciation hints. |
gotcha, i understand now what you are saying! |
It would be useful to be able to give yap a hint as to how to pronounce the name of a town when it reads meeting search results.
For example, if I search for meetings in Yakima, Washington, yap recognizes the town name, but when reading the meetings back, it pronounces it as 'UkEEma'.
The text was updated successfully, but these errors were encountered: