fixes for upgrade advisor

RELEASENOTES.md

@@ -4,6 +4,7 @@
 * Added metrics points for when there is no data. [#530]
 * Fix to handle metrics and reporting bugs for when service body tracking fails [#530]
 * Fix for how metrics service body id lookup happens. [#530] 
+* Fix for upgrade advisor regression. [#589]
 
 ### 4.0.4 (February 18, 2022)
 * Fix for language fallback for volunteers.  It will now correctly use the first language in `language_selections` if none are selected for each volunteer.  Otherwise it will use `language`.

app/Http/Controllers/LegacyController.php

@@ -15,7 +15,7 @@ public function index(Request $request)
             $path .= '/index.php';
         }
 
-        return $this->renderPath($path, str_starts_with($request->path(), 'admin') || str_ends_with($request->path(), 'clear-session.php') ? 'text/html' : 'text/xml');
+        return $this->renderPath($path, str_starts_with($request->path(), 'admin') || str_ends_with($request->path(), 'clear-session.php') ? 'text/html' : str_ends_with($request->path(), 'upgrade-advisor.php') ? 'application/json' : 'text/xml');
     }
 
     public function msr($latitude, $longitude)

legacy/_includes/functions.php

@@ -476,7 +476,7 @@ private static function isThere($setting)
     public static function getState($status = null, $message = null)
     {
         try {
-            $build = file_get_contents("../build.txt", false);
+            $build = file_get_contents("build.txt", false);
         } catch (Exception $e) {
             $build = $e->getMessage();
         }