Swift 4.0 compatibility #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason there are .DS_Store files in your PR. These files should never be included in a project like this. They should be excluded by the project .gitignore or by a global .gitignore, or both. I think you don't have a global .gitignore installed. |
|
Woah you’re right, thanks! New dev setup.
…On Tue, Oct 10, 2017 at 2:35 PM phoney ***@***.***> wrote:
For some reason there are .DS_Store files in your PR. These files should
never be included in a project like this. They should be excluded by the
project .gitignore or by a global .gitignore, or both. I think you don't
have a global .gitignore installed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI02a3hi6jZ0cejhHhXs2sWZxNWwJueYks5sq8bsgaJpZM4PW_8a>
.
|
|
Should someone else make another PR? (I can do it with the same modifications @jjcastro did) |
|
The repo owner appears to no longer maintain this project. I have cloned and renamed it. I already have a Swift 4 version. https://github.com/DavidLari/Haring |
|
Okay. Switched to Haring. Thanks. |
swift 4.2 changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried modifying the bare minimum to get it to work on my swift 4 app. Works nicely (but likely needs a lot of cleanup)