Skip to content

Commit

Permalink
Adding support for negative filter ratios for TSVB (elastic#152053)
Browse files Browse the repository at this point in the history
## Summary

This PR fixes elastic#150738 by adding support for negative denominators for
TSVB's filter ratios.

### Checklist

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
  • Loading branch information
2 people authored and bmorelli25 committed Mar 10, 2023
1 parent 046b977 commit ab8157d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export function ratios(req, panel, series, esQueryConfig, seriesIndex) {
denominator: denominatorPath,
},
script:
'params.numerator != null && params.denominator != null && params.denominator > 0 ? params.numerator / params.denominator : 0',
'params.numerator != null && params.denominator != null && params.denominator != 0 ? params.numerator / params.denominator : 0',
},
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe('ratios(req, panel, series, esQueryConfig, seriesIndex)', () => {
},
script:
'params.numerator != null && params.denominator != null &&' +
' params.denominator > 0 ? params.numerator / params.denominator : 0',
' params.denominator != 0 ? params.numerator / params.denominator : 0',
},
},
'metric-1-denominator': {
Expand Down Expand Up @@ -150,7 +150,7 @@ describe('ratios(req, panel, series, esQueryConfig, seriesIndex)', () => {
},
script:
'params.numerator != null && params.denominator != null &&' +
' params.denominator > 0 ? params.numerator / params.denominator : 0',
' params.denominator != 0 ? params.numerator / params.denominator : 0',
},
},
'metric-1-denominator': {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export const filterRatios: TableRequestProcessorsFunction = ({
denominator: denominatorPath,
},
script:
'params.numerator != null && params.denominator != null && params.denominator > 0 ? params.numerator / params.denominator : 0',
'params.numerator != null && params.denominator != null && params.denominator != 0 ? params.numerator / params.denominator : 0',
},
});
});
Expand Down

0 comments on commit ab8157d

Please sign in to comment.