Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate TIF filtering based on snapshot timestamp instead of current time. #80

Merged
merged 2 commits into from
Mar 5, 2022

Conversation

sean-thorburn
Copy link
Contributor

Filtering for expired orders based on the current time can filter out orders that may not have expired at the time that the snapshot was taken. Instead of filtering by the current time, you can filter by the last update to the book snapshot.

Copy link
Member

@hoakbuilds hoakbuilds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, you make a great point on snapshot timestamp instead of current time.

Could you fix the test to take into account these changes and bump version to 6.0.3.4 so that the pipeline takes care of the rest?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1939235874

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 80.414%

Totals Coverage Status
Change from base Build 1935115420: -0.02%
Covered Lines: 2424
Relevant Lines: 2971

💛 - Coveralls

@hoakbuilds hoakbuilds merged commit 3c93a50 into bmresearch:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants