Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-stage builds in Dockerfile task #607

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Support multi-stage builds in Dockerfile task #607

merged 1 commit into from
Jun 27, 2018

Conversation

orzeh
Copy link
Collaborator

@orzeh orzeh commented Jun 26, 2018

Adds support for multi-stage builds in Dockerfile task.

Fix #606

@orzeh orzeh self-assigned this Jun 26, 2018
@orzeh orzeh requested review from bmuschko and cdancy June 26, 2018 13:14
cdancy
cdancy reviewed Jun 26, 2018
View reviewed changes
Copy link
Collaborator

@cdancy cdancy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for the quick response! I'll see if anyone else has any objections but if not we can merge it by end of day.

@cdancy cdancy added this to the v3.3.7 milestone Jun 26, 2018
@orzeh orzeh merged commit 088ee55 into master Jun 27, 2018
@orzeh orzeh deleted the ISSUE-606 branch June 27, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdancy cdancy cdancy left review comments

@bmuschko bmuschko Awaiting requested review from bmuschko

Assignees

@orzeh orzeh

Labels
enhancement
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@orzeh @cdancy