This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Draft: Add support for mounting additional resources #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebkur
commented
Feb 10, 2022
| path = new File(projectDir, "src/assets/vendor") | ||
| mountpoint = "/client" | ||
| } | ||
| } |
There was a problem hiding this comment.
Here's an example on how to configure this in the target application
sebkur
commented
Feb 10, 2022
| @Override | ||
| void addResource(Resource resource) { | ||
| context.resources.createWebResourceSet(getResourceSetType('PRE'), resource.mountpoint, resource.path.toURI().toURL(), '/') | ||
| } |
There was a problem hiding this comment.
It's straight-forward to mount the resources on Tomcat 8+
sebkur
commented
Feb 10, 2022
| @@ -40,6 +40,11 @@ abstract class BaseTomcatServerImpl implements TomcatServer { | |||
| context.loader.addRepository(resource.toURI().toURL().toString()) | |||
| } | |||
|
|
|||
| @Override | |||
| void addResource(Resource resource) { | |||
| // TODO: how to implement this here for Tomcat 7x? | |||
There was a problem hiding this comment.
However I haven't found out how to do it on Tomcat7.
I'm not sure if it's worth finding a solution for Tomcat7; maybe Tomcat7 should be removed anyway and instead support for Tomcat 10 be implemented as a replacement? #204
|
Here's an example web app using the feature: https://github.com/sebkur/example-web-app Note that it depends on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the plugin to a web app I work on. Works nicely, I just found I couldn't configure something that I usually configure for development in Eclipse and deployment as WAR files: additional resources that are mounted at a specific location of the web app.
I usually use this to make client side JavaScript/CSS libraries available at a specific location and also serve static files generated by other Gradle plugins.