Fix type hierarchy comparisons of types no longer visible in API #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmil
requested review from
adamgic,
fabiomcarneiro,
fwagner,
klink182 and
marafelismino
as code owners
adamgic
reviewed
Oct 23, 2025
adamgic
reviewed
Oct 23, 2025
adamgic
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When types are no longer part of the public API but are needed to derive the type relation (like to find our if the new type is wider / narrower as the old one) then the type hierarchy used to calculate that information did no longer know about the type and its relations.
This PR merges the TypeHierarchy by taking all types not known in the new TypeHierarchy from the old one.
Type of Change
Fixes #251