Make zubbi-web work with path-like role names #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zubbi-scraper is now able to parse roles that are defined in a nested
directory structure. Those roles have a path-like name, e.g. foo/bar.
In order to show those roles properly in zubbi-web, we have to urlencode
the role names in the URL for the details view and also escape the
special characters ("/") in the Elasticsearch query string. The latter
one was already done in other places, so this just aligns the details
query with the "normal" search query.
westphahl
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zubbi-scraper is now able to parse roles that are defined in a nested
directory structure. Those roles have a path-like name, e.g. foo/bar.
In order to show those roles properly in zubbi-web, we have to urlencode
the role names in the URL for the details view and also escape the special
characters ("/") in the Elasticsearch query string. The latter one was
already done in other places, so this just aligns the details query with
the "normal" search query.