change minimum length to 2 #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Jan 11, 2021
types/coin.go
Outdated
| ) | ||
|
|
||
| // ParseCoin parses a cli input for one coin type, returning errors if invalid. | ||
| // This returns an error on an empty string as well. | ||
| func ParseCoin(coinStr string) (coin Coin, err error) { | ||
| coinStr = strings.TrimSpace(coinStr) | ||
|
|
||
| matches := reCoin.FindStringSubmatch(coinStr) | ||
| var matches []string | ||
| if UpgradeMgr.GetHeight() == 0 || IsUpgrade(AdjustTokenSymbolLength) { |
There was a problem hiding this comment.
UpgradeMgr.GetHeight() == 0 why add this condition?
fletcher142
force-pushed
the
symbol_length
branch
from
a9aa3c9
to
0fbea09
Compare
abelliumnt
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: