hardfork: add bsc chainID to encodeSigHeader when submitting evidence for slashing #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add chainID as a parameter fix test header_test.go update sys library updated side chain ID and tests tests working correctly now, sideConAddr changed due to missing private key Remove print bep174: add bsc chainID to encodeSigHeader when submitting evidence for slashing bep174: add bsc chainID to encodeSigHeader when submitting evidence for slashing
randyahx
changed the title
randyahx
changed the title
unclezoro
reviewed
Dec 15, 2022
unclezoro
reviewed
Dec 15, 2022
unclezoro
reviewed
Dec 15, 2022
unclezoro
reviewed
Dec 15, 2022
unclezoro
reviewed
Dec 15, 2022
unclezoro
reviewed
Dec 15, 2022
unclezoro
reviewed
Dec 16, 2022
x/slashing/handler_sidechain.go
Outdated
| sideConsAddr2, err = msg.Headers[1].ExtractSignerFromHeader(chainID) | ||
| } else { | ||
| sideConsAddr, err = msg.Headers[0].ExtractSignerFromHeader(nil) | ||
| sideConsAddr2, err = msg.Headers[1].ExtractSignerFromHeader(nil) |
There was a problem hiding this comment.
The err will be overwritten here. We should have err and err2 here.
j75689
reviewed
Dec 16, 2022
j75689
reviewed
Dec 16, 2022
j75689
reviewed
Dec 16, 2022
j75689
reviewed
Dec 16, 2022
j75689
reviewed
Dec 19, 2022
j75689
reviewed
Dec 19, 2022
j75689
approved these changes
Dec 19, 2022
unclezoro
changed the title
unclezoro
approved these changes
Dec 21, 2022
This was referenced Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of issue submitted:
In BSC sealHash is calculated taking into account Chain ID. However encodeSigHeader does not take into account chainID, meaning that sealHash will return an incorrect hash, thus ExtractSignerFromHeader() returns an invalid signer. In BSC header hash is Sealed including chainID, so encodeSigHeader() must include the chain ID.
Changes:
Added bsc chainID as a param in encodeSigHeader
Added sideChainIdFromText to convert chainID text inputs to big.Int
Tested by submitting doublesign evidence using bsc-double-sign-sdk before and after BEP174 upgrade.
Results: Validator put into jail