fix: fix the breaking change of genesis state for testnet #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #320 +/- ##
===========================================
- Coverage 46.49% 46.48% -0.02%
===========================================
Files 242 242
Lines 23187 23192 +5
===========================================
Hits 10781 10781
- Misses 11761 11764 +3
- Partials 645 647 +2 |
yutianwu
force-pushed
the
fix_testnet
branch
2 times, most recently
from
b0109bc
to
4158eb9
Compare
unclezoro
approved these changes
Feb 1, 2023
This was referenced Feb 1, 2023
This was referenced Mar 23, 2023
|
With all love and help will fix alright |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will fix the syncing issue of testnet.
The root cause is the genesis params are changed after the testnet setup and the genesis params are not read from the genesis file but from the code.
This pr will fix the breaking change of the genesis params so users can syncing from genesis state for tesnet.