Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Coin to fix amount calculation issues #323

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

forcodedancing
Copy link
Contributor

Description

The Plus/Minus functions do not handle amount calculation correctly for some special cases. This pr will add safePlus safeMinus helper functions to handle the issue.

Rational

Fix amount calculation issues.

Examples

NA

@codecov-commenter
Copy link

Codecov Report

Merging #323 (0ed0109) into develop (28669c3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #323      +/-   ##
===========================================
+ Coverage    46.42%   46.45%   +0.02%     
===========================================
  Files          242      242              
  Lines        23221    23231      +10     
===========================================
+ Hits         10781    10791      +10     
  Misses       11793    11793              
  Partials       647      647              

@forcodedancing forcodedancing merged commit 0ea7132 into bnb-chain:develop Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants