fix: use height in store for checking upgrade status #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
approved these changes
Apr 24, 2023
4 tasks
buddh0
pushed a commit
that referenced
this pull request
Apr 25, 2023
buddh0
pushed a commit
that referenced
this pull request
Apr 25, 2023
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will fix the issue that we can not get the right commit id when there is a fork to calculate the hash of the merkle tree.
It will use the height of the commit itself to check the upgrade status instead of the height set in begin block when calculating the hash of the merkle trees.
Rationale
Fix issue calculate store hash.
Example
N/A
Changes
Notable changes: