core/vote: not vote if too late for next in turn validator (#2568)

bnb-chain · Jul 11, 2024 · c96fab0 · c96fab0
1 parent 27d8694
commit c96fab0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/consensus/parlia/parlia.go b/consensus/parlia/parlia.go
@@ -307,6 +307,10 @@ func New(
  return c
 }
 
+func (p *Parlia) Period() uint64 {
+ return p.config.Period
+}
+
 func (p *Parlia) IsSystemTransaction(tx *types.Transaction, header *types.Header) (bool, error) {
  // deploy a contract
  if tx.To() == nil {

diff --git a/core/vote/vote_manager.go b/core/vote/vote_manager.go
@@ -4,9 +4,11 @@ import (
  "bytes"
  "fmt"
  "sync"
+ "time"
 
  "github.com/ethereum/go-ethereum/common"
  "github.com/ethereum/go-ethereum/consensus"
+ "github.com/ethereum/go-ethereum/consensus/parlia"
  "github.com/ethereum/go-ethereum/core"
  "github.com/ethereum/go-ethereum/core/types"
  "github.com/ethereum/go-ethereum/eth/downloader"
@@ -139,6 +141,15 @@ func (voteManager *VoteManager) loop() {
  }
 
  curHead := cHead.Block.Header()
+ if p, ok := voteManager.engine.(*parlia.Parlia); ok {
+ nextBlockMinedTime := time.Unix(int64((curHead.Time + p.Period())), 0)
+ timeForBroadcast := 50 * time.Millisecond // enough to broadcast a vote
+ if time.Now().Add(timeForBroadcast).After(nextBlockMinedTime) {
+ log.Warn("too late to vote", "Head.Time(Second)", curHead.Time, "Now(Millisecond)", time.Now().UnixMilli())
+ continue
+ }
+ }
+
  // Check if cur validator is within the validatorSet at curHead
  if !voteManager.engine.IsActiveValidatorAt(voteManager.chain, curHead,
  func(bLSPublicKey *types.BLSPublicKey) bool {