Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new fork block and precompile contract for BEP294 and BEP299 #1874

Merged
merged 4 commits into from
Nov 30, 2023
Merged

feat: add new fork block and precompile contract for BEP294 and BEP299 #1874

merged 4 commits into from
Nov 30, 2023

Conversation

pythonberg1997
Copy link
Contributor

@pythonberg1997 pythonberg1997 commented Sep 18, 2023 •
edited by j75689
Loading

Description

This pr is to support

  • BEP-294: BSC Native Staking after BC Fusion
  • BEP-299: Token Migration after BC Fusion

Rationale

See 4. Motivation in BEP-294, BEP-299,

Changes

Notable changes:

  • add new precompile contract verifyDoubleSignEvidence and secp256k1SignatureRecover
  • add new systemTx to parlia to update validatorSet everyday after the fusion fork
  • add upgrade setting

unclezoro
unclezoro reviewed Sep 18, 2023
View reviewed changes
core/vm/contracts.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Sep 18, 2023
View reviewed changes
core/vm/contracts.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Sep 18, 2023
View reviewed changes
core/vm/contracts.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Sep 18, 2023
View reviewed changes
core/vm/contracts.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Sep 18, 2023
View reviewed changes
core/vm/contracts.go Outdated Show resolved Hide resolved
@pythonberg1997 pythonberg1997 force-pushed the bc-fusion branch 3 times, most recently from 639fe27 to 12214ef Compare October 26, 2023 10:41
@pythonberg1997 pythonberg1997 changed the base branch from master to develop October 26, 2023 10:44
unclezoro
unclezoro reviewed Oct 31, 2023
View reviewed changes
consensus/parlia/fusionfork.go Outdated
sort.SliceStable(validatorHeap, validatorHeap.Less)
} else {
i := 0
for len(validatorHeap) < int(maxElectedValidators.Int64()) && i < len(allValidators) {
Copy link
Collaborator

@unclezoro unclezoro Oct 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is complicated than I think.

Let's simplify it:
we get allVotingPowers slice, heap.init() it, then pop until 1. top maxElectedValidators, or 2. the heap is empty. Each pop item goes to eligibleValidators

@j75689 j75689 changed the title feat: add new fork block and precompile contract for BEP294 feat: add new fork block and precompile contract for BEP294 and BEP299 Nov 10, 2023
j75689
j75689 reviewed Nov 10, 2023
View reviewed changes
core/types/block.go Outdated Show resolved Hide resolved
buddh0
buddh0 reviewed Nov 20, 2023
View reviewed changes
consensus/parlia/parlia.go Outdated Show resolved Hide resolved
buddh0
buddh0 reviewed Nov 20, 2023
View reviewed changes
miner/worker.go Outdated Show resolved Hide resolved
@unclezoro unclezoro changed the base branch from develop to bc-fusion November 30, 2023 03:06
unclezoro
unclezoro reviewed Nov 30, 2023
View reviewed changes
core/vm/contracts.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Nov 30, 2023
View reviewed changes
params/config_test.go Outdated Show resolved Hide resolved
@unclezoro unclezoro merged commit 030e416 into bnb-chain:bc-fusion Nov 30, 2023
5 checks passed
octavio12345300
octavio12345300 reviewed Sep 30, 2024
View reviewed changes
Copy link

@octavio12345300 octavio12345300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gracias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanBSC NathanBSC NathanBSC left review comments

@octavio12345300 octavio12345300 octavio12345300 left review comments

@j75689 j75689 j75689 left review comments

@buddh0 buddh0 buddh0 left review comments

@ABDALLA10FATHY ABDALLA10FATHY ABDALLA10FATHY approved these changes

@Gabo139 Gabo139 Gabo139 approved these changes

@unclezoro unclezoro unclezoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pythonberg1997 @unclezoro @buddh0 @j75689 @octavio12345300 @NathanBSC @Gabo139 @ABDALLA10FATHY