Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/vm: clean up evm clearly when get it from pool #1914

Merged
merged 1 commit into from
Oct 11, 2023
Merged

core/vm: clean up evm clearly when get it from pool #1914

merged 1 commit into from
Oct 11, 2023

Conversation

NathanBSC
Copy link
Contributor

@NathanBSC NathanBSC commented Oct 11, 2023 •
edited
Loading

Description

core/vm: clean up evm clearly when get it from pool

Rationale

before big merge, code is following

evm.abort = 0

miss it when big merge

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

brilliant-lx
brilliant-lx approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@brilliant-lx brilliant-lx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems only RPCs call like traceCall will trigger this issue.

@brilliant-lx brilliant-lx merged commit 73cfed0 into bnb-chain:master Oct 11, 2023
5 checks passed
@NathanBSC NathanBSC deleted the reset_evm_get_from_pool branch October 12, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zlacfzy zlacfzy zlacfzy approved these changes

@weiihann weiihann weiihann approved these changes

@brilliant-lx brilliant-lx brilliant-lx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NathanBSC @zlacfzy @weiihann @brilliant-lx