Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support db engine with pebble on 32 bits and OpenBSD #2012

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

flywukong
Copy link
Contributor

@flywukong flywukong commented Nov 28, 2023

Description

cockroachdb/pebble#2878 the pebble version that used by bsc has already supported 32-bit . So the judgment logic which disabled the 32-bit environments needs to be removed
The default db is still leveldb.

Rationale

support db engine with pebble on 32 bits and OpenBSD too

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Copy link
Contributor

@sysvm sysvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fynnss fynnss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzckck zzzckck merged commit 0b632d9 into bnb-chain:develop Dec 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants