Write genesis into config file when init network #2059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddh0
changed the title
buddh0
force-pushed
the
write_genesis_into_config_file_initNetwork
branch
from
f242880 to
31226f8
Compare
zlacfzy
previously approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write genesis into config file when init network
Rationale
when we use the cmd
init-networkto set up a clustergenesis will not be written into config.toml any more from #1839
it indeed make the
config.tomlfile much more succinct,but we could not configure hardfork blocks or times in
config.tomlany morewe don't always can set hardforks in genesis.json, for example:
a cluster have set hertz hardfork is running, then new version of bsc including shanghai hardfork released.
then the cluster may need to upgrade to the latest version and enable shanghai
the only way is to configure shanghaiTime in the
config.tomlExample
add an example CLI or API response...
Changes
Notable changes: