-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/ethapi: implement eth_getBlockReceipts (#27702) #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Felix Lange <fjl@twurst.com>
zlacfzy
force-pushed
the
eth_getBlockReceipts
branch
2 times, most recently
from
December 14, 2023 12:20
d5e74b2
to
64065e3
Compare
…28358) Switch to using BlockNumber.String() which encodes it correctly for use in the JSON-RPC API.
zlacfzy
force-pushed
the
eth_getBlockReceipts
branch
from
December 14, 2023 12:32
64065e3
to
ba91364
Compare
zzzckck
previously approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
buddh0
previously approved these changes
Dec 14, 2023
TestRPCGetBlockReceipts failed |
zzzckck
approved these changes
Dec 19, 2023
buddh0
approved these changes
Dec 19, 2023
This was referenced Dec 19, 2023
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply eth_getBlcokReceipts, returns the receipts of a block by number or hash.
ethereum/go-ethereum#27702
ethereum/go-ethereum#28087
ethereum/go-ethereum#28358
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: