Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: revive evm test cases #2116

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Dec 27, 2023

Description

tests: revive evm test cases

Rationale

there are a ton of evm test cases maintained by ethereum office, but It's not run by bsc.
this PR is to revive these test cases and add them as a CI,
image
this will help a lot for quaility assurance.

PS: in block_test.go and state_test.go, the test scope is not less in go-thereum.

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 marked this pull request as draft December 27, 2023 10:23
@buddh0 buddh0 changed the title keep same test scope with go-ethereum tests: revive evm test cases Dec 27, 2023
@buddh0 buddh0 force-pushed the revive-tests branch 4 times, most recently from bc3bf0b to 2ccecad Compare January 3, 2024 10:42
@buddh0 buddh0 force-pushed the revive-tests branch 6 times, most recently from d84f12f to ed32699 Compare January 8, 2024 10:20
@buddh0 buddh0 marked this pull request as ready for review January 8, 2024 10:43
@buddh0 buddh0 force-pushed the revive-tests branch 4 times, most recently from 38a0ac7 to a90903e Compare January 9, 2024 01:25
Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzckck zzzckck merged commit 8ed5d24 into bnb-chain:develop Jan 10, 2024
6 checks passed
@buddh0 buddh0 deleted the revive-tests branch January 19, 2024 03:25
sysvm pushed a commit to sysvm/bsc that referenced this pull request Jan 22, 2024
@zzzckck zzzckck mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants