Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix systemcontracts.GenesisHash when run bsc firstly without init #2132

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Jan 4, 2024

Description

core: fix systemcontracts.GenesisHash when run bsc firstly without init

Rationale

after #2015 and #2100
bsc mainnet and chapel can run without geth init

but may lead a empty genesis hash when first startup, this PR is to fix it

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 changed the title Systemcontracts genesis hash core: set systemcontracts.GenesisHash without geth init Jan 4, 2024
@buddh0 buddh0 changed the base branch from master to develop January 4, 2024 09:01
@buddh0 buddh0 requested review from zlacfzy and weiihann January 4, 2024 09:18
@buddh0 buddh0 force-pushed the systemcontracts_GenesisHash branch from 1a12ff5 to e94d6f4 Compare January 4, 2024 09:20
@buddh0 buddh0 changed the title core: set systemcontracts.GenesisHash without geth init core: fix systemcontracts.GenesisHash when run bsc firstly without init Jan 4, 2024
@buddh0 buddh0 merged commit 73d19c0 into bnb-chain:develop Jan 4, 2024
5 checks passed
@buddh0 buddh0 deleted the systemcontracts_GenesisHash branch January 19, 2024 03:25
sysvm pushed a commit to sysvm/bsc that referenced this pull request Jan 22, 2024
@zzzckck zzzckck mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants