Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add disk io read write bytes #2265

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

fynnss
Copy link
Contributor

@fynnss fynnss commented Mar 8, 2024

Description

In the context of disk information within a process, "rchar" and "readbytes" are two distinct metrics that measure the performance of disk read operations. The key differences and the aspects they focus on:

rchar measures the total number of characters read from the disk, regardless of whether these characters are cached. This includes characters read into the cache as well as those read directly from the disk. It is a broader metric, taking into account all data read from the disk.

readbytes measures the actual number of bytes read from the disk to the user space. Unlike rchar, readbytes does not include data read into the cache; it focuses solely on the amount of data transmitted to the application. This provides a more accurate reflection of the impact of disk reads on the application.

In some cases, the value of rchar may be greater than that of readbytes, as rchar considers all read operations, including data read into the cache.

However, when analyzing the impact of the disk on geth's performance, readbytes is typically more useful.

Rationale

makes it easy to get the real bandwidth consumption of the disk to determine if it is a disk bottleneck or not

Example

NA

Changes

Notable changes:

  • NA

@fynnss fynnss force-pushed the add_disk_io_read_write_bytes branch from c3a60f8 to 4f35b68 Compare March 11, 2024 02:00
@fynnss fynnss requested review from buddh0 and RenRick March 12, 2024 03:14
@zzzckck zzzckck merged commit 7169e2b into bnb-chain:develop Mar 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants