blobtx: fix some found issues; #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emailtovamos
reviewed
Apr 9, 2024
| if err != nil { | ||
| return err | ||
| } | ||
| if blobFrozen > 0 { |
There was a problem hiding this comment.
How does this condition means freezer env is missing? A blob can still freeze by default right?
There was a problem hiding this comment.
yes, this condition means that env must be guaranteed to exist when the blob table already has data.
buddh0
approved these changes
Apr 10, 2024
emailtovamos
approved these changes
Apr 10, 2024
zzzckck
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
blobtx: fix some found issues;
Rationale
The newly added freezer table(BlobTable) relies on
FreezerEnv, so add some code to detect that scenario.Changes
Notable changes: