eth/protocols/eth: add JustifiedNumber into StatusPacket
#2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddh0
force-pushed
the
select_sync_peer_use_justified_than_td
branch
8 times, most recently
from
cbb9f3e
to
b4baf2d
Compare
buddh0
force-pushed
the
select_sync_peer_use_justified_than_td
branch
from
b4baf2d
to
093d504
Compare
zlacfzy
approved these changes
Sep 14, 2024
zzzckck
reviewed
Sep 18, 2024
zzzckck
reviewed
Sep 18, 2024
Ethiqque
reviewed
Sep 26, 2024
Comment on lines
+159
to
+161
| // Head constructs a function to retrieve a peer's current head hash, | ||
| // justifiedNumber and total difficulty. | ||
| func (dlp *downloadTesterPeer) Head() (common.Hash, *uint64, *big.Int) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eth/protocols/eth: add
JustifiedNumberinto StatusPacketRationale
Until now, when a node attempts to select a peer for full synchronization, it only compares peers based on td (total difficulty). However, the correct logic should follow the approach in ReorgNeededWithFastFinality:
Relying solely on td can cause a node to select the wrong peer for synchronization. In certain edge cases, this can split the network and cause the chain to stall, as was observed in the chapel network.
To resolve this issue:
To avoid creating a new version of the Ethereum protocol (e.g., eth70), the fix can be implemented in three phases:
This pull request (PR) covers only the first phase. The following two phases are ready, requiring just one or two lines of code to be uncommented.
Example
add an example CLI or API response...
Changes
Notable changes: