Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove pipecommit #2742

Merged
merged 1 commit into from
Oct 23, 2024
Merged

feat: remove pipecommit #2742

merged 1 commit into from
Oct 23, 2024

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Oct 22, 2024 •
edited
Loading

Description

feat: remove pipecommit

Rationale

pipecommit is brought in [[R4R] implement State Verification && Snapshot Commit pipeline](#668)

  1. this feature is broken now
  2. not easy to recover, and no plan to rework it
  3. this feature changed some interfaces, make code upstream a bit more difficulty

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 force-pushed the remove_pipecommit branch 11 times, most recently from 21d7984 to 09e9249 Compare October 23, 2024 06:52
@buddh0 buddh0 force-pushed the remove_pipecommit branch from 09e9249 to ecb1068 Compare October 23, 2024 07:17
@buddh0 buddh0 marked this pull request as ready for review October 23, 2024 07:37
@zzzckck zzzckck merged commit caa9e79 into bnb-chain:develop Oct 23, 2024
7 checks passed
@zzzckck zzzckck mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzckck zzzckck zzzckck approved these changes

@galaio galaio galaio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buddh0 @galaio @zzzckck