[R4R] add extension in eth protocol handshake to disable tx broadcast #412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new protocol version
67
in eth protocol, and add another round of handshake if peer's protocol version is larger than67
. In the new handshake message, we added an extennsion to control some new features. Currently, we only add a switch to turn off tx broadcast to the connected peer. but we can add more options in the future without adding new params.Rationale
Some nodes may do not need to receive txs broadcasted from other peers. When the network is congested, these nodes will take a lot of time to handle these txs and be unstable for queries. So we add a switch to turn off the tx broadcast for some specific nodes to make the network more stable.
Example
Changes
Notable changes:
67
Preflight checks
make build
)make test
)Already reviewed by
...
Related issues
... reference related issue #'s here ...