Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]fix downloader nil issue when the header is mising #471

Merged
merged 1 commit into from
Oct 20, 2021
Merged

[R4R]fix downloader nil issue when the header is mising #471

merged 1 commit into from
Oct 20, 2021

Conversation

unclezoro
Copy link
Collaborator

@unclezoro unclezoro commented Oct 20, 2021 •
edited
Loading

Description

fix downloader nil issue when the header is mising

Rationale

still refer to the header when the header is nil

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • manual transaction test passed

Already reviewed by

...

Related issues

... reference related issue #'s here ...

@unclezoro unclezoro changed the title [R4R]fix download nil issue [R4R]fix downloader nil issue when the header is mising Oct 20, 2021
@unclezoro unclezoro merged commit b6035c1 into bnb-chain:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j75689 j75689 j75689 approved these changes

@yutianwu yutianwu yutianwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unclezoro @yutianwu @j75689