Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update goleveldb #578

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

flywukong
Copy link
Contributor

@flywukong flywukong commented Nov 23, 2021

Description

merge goleveldb changes on memory alloction

  1. Reduce memory allocation of buffer_pool and db
util/buffer_pool, db: Reduce memory allocation util/buffer_pool, db: Reduce memory allocation syndtr/goleveldb#367
  2. snappy-4.0.0 upgrade
Updated snappy version Updated snappy version syndtr/goleveldb#365

it is already merged in geth

Rationale

this update help reducing memory allocation of leveldb ,
after tested on full sync mode , the updated leveldb will reduce the memory usage by 4%-5%, and it is more stable from the memory curve

Example

@unclezoro
Copy link
Collaborator

LGTM

Copy link

@RenRick RenRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unclezoro unclezoro merged commit 1d94308 into bnb-chain:develop Nov 24, 2021
This was referenced Nov 29, 2021
j75689 pushed a commit that referenced this pull request Nov 29, 2021
Co-authored-by: ucwong <ucwong@126.com>
keefel pushed a commit to keefel/bsc that referenced this pull request Jun 6, 2022
Co-authored-by: ucwong <ucwong@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants