[R4R]reorganize the logic of reannouncing transactions #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keefel
changed the title
unclezoro
approved these changes
Dec 2, 2021
yutianwu
approved these changes
Dec 2, 2021
kyrie-yl
approved these changes
Dec 2, 2021
unclezoro
pushed a commit
that referenced
this pull request
Dec 20, 2021
unclezoro
pushed a commit
that referenced
this pull request
Dec 20, 2021
keefel
added a commit
to keefel/bsc
that referenced
this pull request
Dec 20, 2021
keefel
added a commit
to keefel/bsc
that referenced
this pull request
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous logic of reannouncing transactions is a little bit redundant, we reorganize the logic to replace the double loop.
Rationale
The function has not changed, just reorganize the code to make it look more concise.
Example
go test -v -run TestTransactionPendingReannounce ./eth/*.go--- PASS: TestTransactionPendingReannounce (0.62s)Changes
No