Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
panic with nil pointer of
Transaction.inner
Rationale
If
PrefetchMining
run fast enough that sub-prefetcher-routines checkedtxCurr
before transaction had been peeked fromTransactionByPriceAndNonce
at the main worker routine, it would get an emptyTransaction
struct with nilinner
filed which would cause panic infunc (s EIP155Signer) Sender(tx *Transaction) (common.Address, error)
Example
N/A
Changes
Notable changes:
Transaction
for tx initialization,Peek
the firsttransaction
fromTransactionByPriceAndNonce
for current transactiontxCurr
atminer/worker.go:line787
which would be accessed in mining-prefetcher-routine