Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement cmd to sign validator ownership #1004

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

j75689
Copy link
Contributor

@j75689 j75689 commented Jan 22, 2024

Description

feat: implement cmd to sign validator ownership

Rationale

bsc validator on bc can sign their sigs to prove the ownership to the new operator address on bsc after bc-fusion

Example

./build/tbnbcli validator-ownership sign-validator-ownership --bsc-operator-address 0x45737bAf95D995a963ab3a7c9AC66fC7A63ad76E --from test1 --chain-id Binance-Chain-Ganges

Changes

Notable changes:

  • cmd

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • integration tests passed (make integration_test)
  • manual transaction test passed (cli invoke)

Already reviewed by

n/a

Related issues

n/a

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3ab169) 48.80% compared to head (17f6bb4) 48.75%.
Report is 5 commits behind head on bc-fusion.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           bc-fusion    #1004      +/-   ##
=============================================
- Coverage      48.80%   48.75%   -0.05%     
=============================================
  Files            127      127              
  Lines          12811    12820       +9     
=============================================
- Hits            6252     6251       -1     
- Misses          6127     6138      +11     
+ Partials         432      431       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unclezoro unclezoro merged commit fa46382 into bnb-chain:bc-fusion Jan 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants