Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add sunsethardfork config and fix panic issue #988

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

j75689
Copy link
Contributor

@j75689 j75689 commented Dec 14, 2023

Description

  1. add sunsethardfork config
  2. ibc keeper did not set it correctly

Rationale

scKeeper is not copied when the app init stage. and it will panic in EndBlock to call the ibc.scKeeper

Example

n/a

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • integration tests passed (make integration_test)
  • manual transaction test passed (cli invoke)

Already reviewed by

...

Related issues

... reference related issue #'s here ...

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (09b52c7) 48.82% compared to head (ce87dd3) 48.84%.

Files Patch % Lines
app/config/config.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           bc-fusion     #988      +/-   ##
=============================================
+ Coverage      48.82%   48.84%   +0.02%     
=============================================
  Files            127      127              
  Lines          12788    12795       +7     
=============================================
+ Hits            6244     6250       +6     
- Misses          6114     6115       +1     
  Partials         430      430              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j75689 j75689 changed the title fix: panic issue when doing refundStake and closeCorssChainChannel fix: add sunsethardfork config and fix panic issue Dec 14, 2023
@unclezoro unclezoro merged commit 5ee5e0f into bc-fusion Dec 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants